Fix up generated go code for arrays#872
Closed
andrewstucki wants to merge 1 commit intoelastic:mainfrom
Closed
Conversation
Contributor
|
If this Golang library is in use, it should be moved to a different repo. I'll be happy to help do that. The ECS team doesn't have the resources or expertise to maintain it, and therefore issues raised about this library are not being addressed (see bug reports linked here ). |
Member
|
Go code generator was removed in #1567 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed recently when fixing up some packetbeat code that the generated structures for go don't respect array normalization--makes it so we have to do some gross stuff like this as a workaround right now:
I'll see about adding in some json/
common.MapStrserializers at some point in a follow-up.